fix(elements): use --media-font-family so timecode font settings apply - #452
Open
ephraimduncan wants to merge 1 commit into
Open
fix(elements): use --media-font-family so timecode font settings apply#452ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioPlayersets--media-font: var(--font-sans)onMediaController, but media-chrome'sMediaTextDisplayuses--media-fontas the complete value of the CSSfontshorthand:var(--font-sans)resolves to a bare font-family list, which is not a validfontshorthand, so the declaration becomes invalid at computed-value time and is dropped. Two consequences:ButtonGroupTexttypography (text-sm font-medium) instead of the configured compact font.--media-fontis defined, thevar()fallback never runs, so the sibling--media-font-size: 10pxis dead configuration.Fix
Swap the malformed shorthand for the constituent variable:
This makes the existing
--media-font-size: 10pxlive and applies to every text display under the controller (time, duration, preview text). Consumer overrides still win via the trailing...stylespread, and a consumer-supplied valid--media-fontshorthand still takes precedence per media-chrome's fallback ordering.Verification
Reproduced media-chrome's exact
:hostfont:declaration in a headless browser with a parent styled14px/500/Georgia: