chore(deps): bump the tokio group across 1 directory with 2 updates#25544
chore(deps): bump the tokio group across 1 directory with 2 updates#25544dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the tokio group with 2 updates in the / directory: [tokio](https://github.com/tokio-rs/tokio) and [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite). Updates `tokio` from 1.52.2 to 1.52.3 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.2...tokio-1.52.3) Updates `tokio-tungstenite` from 0.20.1 to 0.29.0 - [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md) - [Commits](snapview/tokio-tungstenite@v0.20.1...v0.29.0) --- updated-dependencies: - dependency-name: tokio dependency-version: 1.52.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: tokio - dependency-name: tokio-tungstenite dependency-version: 0.29.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tokio ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b0cc526c5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tokio-stream = { version = "0.1.18", default-features = false } | ||
| tokio-test = "0.4.5" | ||
| tokio-tungstenite = { version = "0.20.1", default-features = false } | ||
| tokio-tungstenite = { version = "0.29.0", default-features = false } |
There was a problem hiding this comment.
Preserve websocket buffer sizing
With this bump, every Vector websocket connection that uses tungstenite defaults now gets the newer WebSocketConfig::read_buffer_size default of 128 KiB, and that buffer is eagerly allocated. The websocket client path currently calls WebSocketConfig::default() in src/common/websocket.rs, and the websocket server path uses accept_hdr_async without passing a config, so deployments with many websocket source/server connections can see a large RSS increase compared with the old 0.20.x defaults unless we explicitly configure the previous smaller read buffer.
Useful? React with 👍 / 👎.
| name = "tungstenite" | ||
| version = "0.20.1" | ||
| version = "0.29.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" |
There was a problem hiding this comment.
Regenerate the license inventory
Because this bump removes tungstenite's transitive utf-8 dependency from Cargo.lock but leaves LICENSE-3rdparty.csv unchanged, make check-licenses/CI will still see an inventory entry for a crate no longer in the resolved dependency graph. Regenerate the license inventory (e.g. make build-licenses) as part of this dependency update so the packaged third-party license list matches the lockfile.
Useful? React with 👍 / 👎.
| tokio-stream = { version = "0.1.18", default-features = false } | ||
| tokio-test = "0.4.5" | ||
| tokio-tungstenite = { version = "0.20.1", default-features = false } | ||
| tokio-tungstenite = { version = "0.29.0", default-features = false } |
There was a problem hiding this comment.
Migrate websocket handshakes to http 1
Upgrading to tokio-tungstenite 0.29 also moves tungstenite's handshake Request/Response types from http 0.2 to http 1, but the websocket paths still pass those values to helpers typed against this crate's http 0.2 API (auth.apply(&mut request) in the client connector, and auth.handle_auth(..., req.headers(), ...) plus StatusCode::UNAUTHORIZED in the server callback). Enabling sources-websocket or sinks-websocket-server will fail to build until these handshakes use http-1-compatible types or explicitly convert between versions.
Useful? React with 👍 / 👎.
Bumps the tokio group with 2 updates in the / directory: tokio and tokio-tungstenite.
Updates
tokiofrom 1.52.2 to 1.52.3Release notes
Sourced from tokio's releases.
Commits
d875691chore: prepare Tokio v1.52.3 (#8130)e1aebb0Merge 'tokio-1.51.3' into 'tokio-1.52.x' (#8129)fd63094chore: prepare Tokio v1.51.3 (#8127)8c600d0Merge 'tokio-1.47.5' into 'tokio-1.51.x' (#8123)11bfc13chore: prepare Tokio v1.47.5 (#8122)f085b62sync: notify receivers in mpscOwnedPermit::release()method (#8075)30d25ccsync: require that anRwLockhasmax_readers != 0(#8076)9fccf53sync: returnEmptyfromtry_recv()when mpsc is closed with outstanding p...ebf61b4sync: fix underflow in mpsc channellen()(#8062)Updates
tokio-tungstenitefrom 0.20.1 to 0.29.0Changelog
Sourced from tokio-tungstenite's changelog.
... (truncated)
Commits
7930ff2Bump version38d0465Update Readme (#369)35d110cImplement into_inner to get the underlying stream (#367)f3ae75dUpdatetungsteniteversion and fix bugs25b544eAllow getting a reference to the shared inner stream (#363)e855f9eFix errors in the examples caused byUtf8Error21c5d19Bump versionfbd1471Update performance notes in READMEa8d9f19Bump versionaafb2f9Bump versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions