chore(deps): bump the tonic group across 1 directory with 2 updates#25543
chore(deps): bump the tonic group across 1 directory with 2 updates#25543dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
domain: deps
dependabot
Bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c43244f8dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-health = { version = "0.14", default-features = false } | ||
| tonic-reflection = { version = "0.14", default-features = false, features = ["server"] } |
There was a problem hiding this comment.
With api or sources-vector enabled, these versions pull tonic-health/tonic-reflection 0.14 while the workspace still depends on tonic/tonic-build 0.11 just above. The health and reflection services from 0.14 are built against the newer tonic/http/hyper stack, so they cannot be added to the existing 0.11 TonicServer/RoutesBuilder call sites in src/api/grpc_server.rs and src/sources/vector/mod.rs; those feature sets stop building unless the whole tonic/prost stack is upgraded together or these crates stay at 0.11.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-d003ba52b2
branch
from
c43244f to
0e711d0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e711d01c0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-build = { version = "0.11", default-features = false, features = ["transport", "prost"] } | ||
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic-health = { version = "0.14", default-features = false } |
There was a problem hiding this comment.
This bump also breaks the always-workspace lib/vector-api-client crate, not just the optional server features already discussed: that crate imports tonic::transport::Channel from the workspace tonic 0.11 while tonic_health::pb::health_client::HealthClient is now generated against tonic 0.14/tonic-prost (as shown in Cargo.lock), so HealthClient::new(channel) in lib/vector-api-client/src/client.rs receives a channel from a different tonic crate and the API client no longer compiles until these versions are upgraded together or tonic-health stays on 0.11.
Useful? React with 👍 / 👎.
Bumps the tonic group with 2 updates in the / directory: [tonic-health](https://github.com/hyperium/tonic) and [tonic-reflection](https://github.com/hyperium/tonic). Updates `tonic-health` from 0.11.0 to 0.14.5 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.11.0...v0.14.5) Updates `tonic-reflection` from 0.11.0 to 0.14.5 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.11.0...v0.14.5) --- updated-dependencies: - dependency-name: tonic-health dependency-version: 0.14.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic - dependency-name: tonic-reflection dependency-version: 0.14.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-d003ba52b2
branch
from
0e711d0 to
ada94fa
Compare
Bumps the tonic group with 2 updates in the / directory: tonic-health and tonic-reflection.
Updates
tonic-healthfrom 0.11.0 to 0.14.5Changelog
Sourced from tonic-health's changelog.
... (truncated)
Commits
3f7caf3chore: prepare v0.14.5 release (#2516)3f56644grpc(chore): add missing copyright notices (#2513)1769c91feat(xds): implement xDS subscription worker (#2478)56f8c6dfeat(grpc): Add TCP listener API in the Runtime trait + tests for server cred...149f366feat(grpc) Add channel credentials API + Insecure credentials (#2495)cd5b32fchore: prepare 0.14.4 release (#2504)27640d2fix(web): allow space after:ingrpc-status(#2506)0c26ee1Fix permission of a series of files (#2502)c25daa6fix(ci): remove comment from manifest to unblock version parsing (#2501)3efc5f9chore(doc): Replace doc_auto_cfg config with doc_cfg (#2428)Updates
tonic-reflectionfrom 0.11.0 to 0.14.5Changelog
Sourced from tonic-reflection's changelog.
... (truncated)
Commits
3f7caf3chore: prepare v0.14.5 release (#2516)3f56644grpc(chore): add missing copyright notices (#2513)1769c91feat(xds): implement xDS subscription worker (#2478)56f8c6dfeat(grpc): Add TCP listener API in the Runtime trait + tests for server cred...149f366feat(grpc) Add channel credentials API + Insecure credentials (#2495)cd5b32fchore: prepare 0.14.4 release (#2504)27640d2fix(web): allow space after:ingrpc-status(#2506)0c26ee1Fix permission of a series of files (#2502)c25daa6fix(ci): remove comment from manifest to unblock version parsing (#2501)3efc5f9chore(doc): Replace doc_auto_cfg config with doc_cfg (#2428)