feat: cwriter for wasm v7 - #133
Conversation
|
Your commits does not support GOOS=wasip1 and GOARCH=wasm |
Solaris-star
left a comment
There was a problem hiding this comment.
This is a superset of #132 — it adds the same WASM stubs plus util_wasm.go for the ioctl constant. Two issues:
-
Build tags: uses the old
//+buildsyntax. Go 1.17+ prefers//go:build. #132 already has the correct syntax — worth aligning. -
IsTerminalreturnstrue: same concern as #132 — WASM has no terminal, sofalseis more accurate. Callers checkingIsTerminalto decide between TTY and plain output would get the wrong branch.
Recommend consolidating #132 and #133 into a single PR with //go:build tags and IsTerminal → false. The core approach (dummy Writer, no-op GetSize) is correct.
|
I rechecked the current head There is a compile blocker for the target platform:
|
No description provided.