fix(docs): prefix internal links with site base, repair broken targets#81
Merged
Conversation
Internal absolute links in markdown were not getting the /simpledeploy base prefix, 404ing on GitHub Pages. Add a remark plugin that rewrites absolute internal URLs and JSX href/src/link attrs at build time. Hero frontmatter patched directly since remark skips frontmatter. Also fix stale link targets surfaced by the link validator: - /guides/users/roles/ -> /guides/users-roles/ - /guides/backups/ -> /guides/backups/overview/ - /simpledeploy/concepts/backups/ -> /guides/backups/overview/ - /trust -> inline note (runtime route, not a docs page) Exclude blog index and localhost dev URLs from the validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base(/simpledeploy) at build time, fixing 404s for hero CTAs, LinkCards, and inline markdown links across the docs site.starlight-links-validator.Test plan
pnpm buildindocs-site/reports 0 invalid linksdist/index.htmlshows internal hrefs prefixed with/simpledeploy/