feat(py/var-config): expose a pure parse_var_config(text, source)#19
Open
AndreasKoestler wants to merge 1 commit into
Open
feat(py/var-config): expose a pure parse_var_config(text, source)#19AndreasKoestler wants to merge 1 commit into
AndreasKoestler wants to merge 1 commit into
Conversation
Split config parsing from the file-reading edge, mirroring TypeScript's parseVarConfig(jsonText, sourcePath) and Java's VarConfig.parse(String, String). parse_var_config(text, source) is a pure function that validates config text and labels every error with the given source; read_var_config is now the thin imperative shell that reads the file and delegates to it. Callers can now parse config text without a file on disk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Hi @AndreasKoestler - thanks a lot! You accidentally added the unrelated Rust port to this PR. Could you separate it please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
TypeScript exposes
parseVarConfig(jsonText, sourcePath)and JavaVarConfig.parse(String, String)— pure text parsers separated from the file-reading edge. Python'sread_var_config(root)fused read + parse, so there was no way to parse config text without a file on disk.Change
parse_var_config(text: str, source: str) -> VarConfig— a pure function (no file I/O) that validates config text and labels everyValueErrorwith the givensource. This is the functional core, mirroring the other ports.read_var_config(root)on top of it: it now only touches the filesystem (missing file → empty config; else read text and delegate), passingstr(path)as the source so error messages are byte-for-byte unchanged.parse_var_configfrom the package.Tests
parse_var_configparses inline text with no file present, and that it labels errors with the caller-suppliedsource.🤖 Generated with Claude Code