Skip to content

Keep viable research PRs active through repair and harvest - #83

Merged
axis-marbell merged 3 commits into
mainfrom
process/pr-lifecycle-active-harvest
Aug 18, 2026
Merged

Keep viable research PRs active through repair and harvest#83
axis-marbell merged 3 commits into
mainfrom
process/pr-lifecycle-active-harvest

Conversation

@vantasnerdan

@vantasnerdan vantasnerdan commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Advances #81

Outcome

This corrects the process failure exposed by the premature closure of #77 and removes unconditional full-suite validation from ordinary PRs.

  • refactor then merge requires an owner or handoff, live source/harvest PR, exact repair, and landing test.
  • Unmerged closure is limited to enumerated terminal cases with unit-level evidence and landed replacement links.
  • Incomplete accepted dependency closure, canon conflict, unavailable self-merge authority, and pending finite repair are explicitly non-terminal.
  • Accepted canon remains authoritative for releases and promotion but scientifically challengeable; correct conditional artifacts can merge without promotion.
  • PR validation now chooses full, affected-test scope, or fixed checks only from the base diff. Additive new modules with matching tests may stay scoped; existing framework-module changes, governance/shared machinery, removals, untested or multi-module additions, and uncertain executable changes force full.
  • Full integrated validation runs weekly or on manual request, rather than on every PR and again after every merge.

The root contract, onboarding, PR template, research harvest and physics skills, five memory templates, workflow/validation scripts, and regression tests agree.

Scope and authority

Validation boundary

  • scripts/validate_changed.py --base main --head HEAD --print-only selects the four affected test files below.
  • scripts/validate.sh --pytest-scope tests/test_public_contribution_surfaces.py tests/test_repository_validation.py tests/test_validate_changed.py tests/test_validate_script.py — PASS: all fixed repository checks plus 32 focused tests.
  • Conservative selector tests cover full/scoped/fixed-only dispatch, existing/new modules, additive/removal public exports, governance, removed tests, workflow drivers, and unmapped documentation.
  • Physics skill validator and skill-creator quick validation — PASS.
  • GitNexus final change detection — LOW risk, zero affected processes.
  • git diff --check — PASS separately.

No full pytest replay was used for this boundary. The earlier interrupted local full attempt and the workflow run produced before the CI correction are not the evidence for this revision.

Merge authority

I authored and implemented this PR and will not merge it. A distinct reviewing agent or repository owner must decide and perform the merge.

Advances #81 by separating PR lifecycle from claim promotion and by making validation scope impact-based.
Advances #81 by recording PR #83 and its distinct-merge boundary.
Advances #81 by replacing unconditional PR-wide pytest with conservative full, scoped, or fixed-only selection and a periodic full backstop.
@vantasnerdan

Copy link
Copy Markdown
Owner Author

CI verification after the workflow correction: Actions run 32122559445 completed successfully in 54 seconds. The log reports Validation mode: scoped, selects exactly the four declared test files, runs 32 tests, and ends with ALL FIXED REPOSITORY CHECKS AND REQUESTED PYTEST SCOPE PASS. The periodic/manual full-validation step was skipped for this PR as intended.

@axis-marbell axis-marbell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Administrative CODEOWNER approval on maintainer authority; no code review performed.

@axis-marbell
axis-marbell merged commit 0beaac3 into main Aug 18, 2026
1 check passed
@axis-marbell
axis-marbell deleted the process/pr-lifecycle-active-harvest branch August 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants