fix: add .js extensions to es build for Node ESM#2720
Open
leno23 wants to merge 1 commit into
Open
Conversation
Closes validatorjs#2528 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2528
Node ESM requires explicit
.jsextensions on relative imports. Thees/build output currently emits imports likefrom './util/assertString'without extensions, causingERR_MODULE_NOT_FOUNDwhen importing individual validators in Node.This adds a post-build step (
scripts/add-es-import-extensions.js) that runs afterbabelinbuild:esand appends.jsto relative import/export paths in the generatedes/tree.Also updates README examples to use the correct
.jspaths for both CommonJS and ESM.Test plan
npm run build:escompletes successfully./es/lib/isEmail.jsworksnpm test— 318 tests passingMade with Cursor