Skip to content

Fix TLS check on uninstall#768

Open
mbaldessari wants to merge 2 commits into
validatedpatterns:mainfrom
mbaldessari:fix-tls-scan
Open

Fix TLS check on uninstall#768
mbaldessari wants to merge 2 commits into
validatedpatterns:mainfrom
mbaldessari:fix-tls-scan

Conversation

@mbaldessari

@mbaldessari mbaldessari commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Drop insecure TLS
  • Add unit tests for the checkSpokeApplicationsGone() function

@mbaldessari
Drop insecure TLS
f561fea 
We read the two CAs in the pod and use those if we find at least one:
/run/secrets/kubernetes.io/serviceaccount/ca.crt
/run/secrets/kubernetes.io/serviceaccount/service-ca.crt

If we can't find any we just assume that we're in a development setup
and we set InsecureSkipVerify = true
@mbaldessari
Add unit tests for the checkSpokeApplicationsGone() function
2a9dcc4
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaldessari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@mbaldessari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/self-test 2a9dcc4 link true /test self-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@day0hero day0hero Awaiting requested review from day0hero
@OAharoni-RedHat OAharoni-RedHat Awaiting requested review from OAharoni-RedHat

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mbaldessari