chore: update pattern infrastructure to upstream patternizer#87
Merged
butler54 merged 2 commits intoMay 27, 2026
Merged
Conversation
Sync pattern.sh and Makefile-common with upstream reference from: https://github.com/validatedpatterns/patternizer/tree/main/resources pattern.sh changes (full replacement): - Add set -euo pipefail strict mode for fail-fast behavior - Convert PODMAN_ARGS, PKI_HOST_MOUNT_ARGS, EXTRA_ARGS from strings to bash arrays - Add :- defaults on all env var checks for set -u compatibility - Fix KUBECONFIG regex: ^/Users/chbutler* → ^"${HOME}" (was matching wrong char) - Add error handling fallbacks for podman --version and podman system connection list - Quote all variable expansions throughout - Use "$1" instead of "$@" in version() function Makefile-common changes: - Change ANSIBLE_STDOUT_CALLBACK default from null to rhvp.cluster_utils.readable - Change ANSIBLE_RUN from := to ?= to allow environment override - Replace stub uninstall target with experimental implementation (calls rhvp.cluster_utils.uninstall playbook) Improves robustness, maintainability, and alignment with VP framework best practices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizes pattern.sh and Makefile-common with upstream patternizer reference.
pattern.sh: full replacement with strict mode, bash arrays, quoting fixes
Makefile-common: update ANSIBLE_STDOUT_CALLBACK, ANSIBLE_RUN, uninstall target
Reference: https://github.com/validatedpatterns/patternizer/tree/main/resources
Part of Wave 1 attestation hardening work.