docs: add example of handling login and re-enabling login form - #5860
Merged
Conversation
web-padawan
requested changes
Aug 10, 2026
HerbertsVaadin
force-pushed
the
feat/78-login-reenable
branch
from
August 11, 2026 08:03
65093e3 to
7b1deb0
Compare
web-padawan
reviewed
Aug 11, 2026
HerbertsVaadin
force-pushed
the
feat/78-login-reenable
branch
from
August 11, 2026 08:05
7b1deb0 to
213e32e
Compare
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-5860.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Built from 33f7e6d |
web-padawan
requested changes
Aug 11, 2026
web-padawan
left a comment
web-padawan
left a comment
Member
There was a problem hiding this comment.
I just realised that this resetting disabled should not be not needed for LoginOverlay as it was fixed in vaadin/web-components#12274.
So, let's remove this from the validation example and create a new example using LoginForm where the problem exists.
HerbertsVaadin
force-pushed
the
feat/78-login-reenable
branch
from
August 12, 2026 09:17
3a0157a to
b5afda3
Compare
HerbertsVaadin
force-pushed
the
feat/78-login-reenable
branch
from
August 12, 2026 09:18
b5afda3 to
65d6765
Compare
web-padawan
changed the title
web-padawan
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #78
Adds the missing piece - include it as a part of the first example.