Conversation
Add util/fetch-gnu.sh (downloads the GNU grep 3.12 release tarball from ftp.gnu.org) and util/run-gnu-testsuite.sh, which reuses the gnulib test framework shipped in the tarball (tests/init.sh + init.cfg) and injects the Rust grep binary via PATH, replicating tests/Makefile.am's TESTS_ENVIRONMENT. Each test is classified by its gnulib exit code (0=PASS, 77=SKIP, else FAIL) and results are emitted as JSON. Modelled on ../sed (lightweight PATH-injection runner) and ../coreutils (release-tarball fetch). Current baseline: 61 pass / 39 fail / 28 skip of 128 tests -- the failures quantify the remaining GNU-compatibility gap.
Add a GnuTests workflow that, on push and PR, fetches the GNU grep release tarball, builds the Rust grep binary, runs util/run-gnu-testsuite.sh, and uploads the JSON results. An aggregate job compares the run against the reference summary from the default branch (util/compare_test_results.py, borrowed from ../sed) and fails only on new, non-intermittent regressions; known-flaky tests are listed in .github/workflows/ignore-intermittent.txt.
Add a GnuComment workflow that runs after GnuTests completes on a pull request, downloads the 'comment' artifact (PR number + comparison text), and posts it as a PR comment. Mirrors ../sed's GnuComment workflow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 6 6
Lines 1404 1404
Branches 139 139
=====================================
Misses 1404 1404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
and it works: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.