grep: don't emit the -T alignment tab on empty lines#12
Open
sylvestre wants to merge 1 commit into
Open
Conversation
|
GNU grep testsuite comparison: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 95.82% 95.90% +0.07%
==========================================
Files 6 6
Lines 1414 1417 +3
Branches 140 141 +1
==========================================
+ Hits 1355 1359 +4
Misses 58 58
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With -T, grep pads the prefix with a tab so line content lands on a tab stop. GNU omits that tab when the line has no content: an empty line prints just its prefix (a whitespace-only line still gets the tab). uu_grep always wrote the tab, so empty matched lines gained a spurious trailing tab. Gate the tab on non-empty content. Fixes the GNU testsuite 'initial-tab' test.
f1388c3 to
a7b1532
Compare
|
GNU grep testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With -T, grep pads the prefix with a tab so line content lands on a tab stop. GNU omits that tab when the line has no content: an empty line prints just its prefix (a whitespace-only line still gets the tab). uu_grep always wrote the tab, so empty matched lines gained a spurious trailing tab. Gate the tab on non-empty content. Fixes the GNU testsuite 'initial-tab' test.