xargs: Account for quoting on Windows for length limits#788
Open
lhecker wants to merge 1 commit into
Open
Conversation
lhecker
commented
Jul 21, 2026
Comment on lines
+158
to
+170
| match wch { | ||
| BACKSLASH => backslashes += 1, | ||
| QUOTE => { | ||
| // Account for n+1 additional backslashes before a quote. | ||
| len += backslashes + 1; | ||
| backslashes = 0; | ||
| } | ||
| SPACE | TAB => { | ||
| quote = true; | ||
| backslashes = 0; | ||
| } | ||
| _ => backslashes = 0, | ||
| } |
Author
There was a problem hiding this comment.
Apologies if this code is quite fugly. I'd also wish Windows had a sane argv system. 🙁
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 35 35
Lines 7159 7159
Branches 376 376
=======================================
Hits 6578 6578
Misses 437 437
Partials 144 144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit ee56ad3 has test result changes: bfs testsuite: |
Author
|
What does that failing test mean? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported at microsoft/coreutils#160.