Skip to content

cmp: use .map_err#236

Draft
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cmp-map_err
Draft

cmp: use .map_err#236
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cmp-map_err

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Jun 3, 2026

No description provided.

@oech3 oech3 marked this pull request as ready for review June 3, 2026 12:24
@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Jun 3, 2026

Merging this PR will degrade performance by 4.77%

❌ 1 regressed benchmark
✅ 25 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cmp_parser 5.6 µs 5.9 µs -4.77%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:cmp-map_err (7c23ada) with main (d266f9b)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

GNU diffutils testsuite comparison:

Test results comparison:
  Current:   TOTAL: 33 / PASSED: 0 / FAILED: 33 / SKIPPED: 0
  Reference: TOTAL: 33 / PASSED: 8 / FAILED: 21 / SKIPPED: 4

Changes from main branch:
  TOTAL: +0
  PASSED: -8
  FAILED: +12

New test failures (12):
  - basic
  - bignum
  - brief-vs-stat-zero-kernel-lies
  - bug-64316
  - cmp
  - diff3
  - help-version
  - large-subopt
  - strcoll-0-names
  - strip-trailing-cr
  - timezone
  - y2038-vs-32bit

marc-hb

This comment was marked as low quality.

@oech3

This comment was marked as resolved.

@marc-hb
Copy link
Copy Markdown
Contributor

marc-hb commented Jun 4, 2026

Need more coffee? Sincere apologies for the noise.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jun 4, 2026

No problem. Thankyou for reviewing.

@oech3 oech3 marked this pull request as draft June 4, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants