Skip to content

cp: fix 2 clippy expections - #13537

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cp-if-not-else
Open

cp: fix 2 clippy expections#13537
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cp-if-not-else

Conversation

@oech3

@oech3 oech3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

remove clippy::if_not_else and clippy::unnecessary_cast allow(unused_variables)

Comment thread src/uu/cp/src/cp.rs Outdated
@RenjiSann

RenjiSann commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Also, it seems that you kept clippy::unnecessary_cast after all, is it expected ?

@oech3

oech3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I typo. I meant allow(unused_variables)

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/seq/seq-epipe is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:cp-if-not-else (e65084d) with main (8aa2c06)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
oech3 requested a review from RenjiSann July 28, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants