numfmt: prevent panic for --format precision > 65535 on remaining paths#13514
Merged
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Merging this PR will degrade performance by 3.47%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | ls_recursive_balanced_tree[(6, 4, 15)] |
49.4 ms | 51.2 ms | -3.47% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing SAY-5:numfmt-precision-guard-remaining (2d43038) with main (0d6b21e)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12600 guarded only the middle branch of the render match in
transform_to, sonumfmt --format=%.70000f 1.5andnumfmt --to=si --format %.70000f 1000000still abort withFormatting argument out of range(#13483). This adds the sameprecision <= u16::MAXguard to the two remainingformat!("{:.precision$}")branches.While testing the suffix path I found
round_with_precisionalso turns the value into NaN for precision >= 309, because10f64.powf(precision)overflows to infinity andinf / infis NaN. Rounding is a no-op at that scale anyway, so it now returns the value unchanged when the scale factor is not finite.Closes #13483