cp: improve the backup support#13505
Open
sylvestre wants to merge 2 commits into
Open
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 22, 2026
| cp-error-failed-to-create-whole-tree = failed to create whole tree | ||
| cp-error-failed-to-create-directory = Failed to create directory: { $error } | ||
| cp-error-backup-format = cp: { $error } | ||
| Try '{ $exec } --help' for more information. |
Contributor
There was a problem hiding this comment.
Suggested change
| Try '{ $exec } --help' for more information. |
cakebaker
reviewed
Jul 22, 2026
| cp-error-failed-to-create-whole-tree = échec de la création de l'arborescence complète | ||
| cp-error-failed-to-create-directory = Échec de la création du répertoire : { $error } | ||
| cp-error-backup-format = cp : { $error } | ||
| Tentez '{ $exec } --help' pour plus d'informations. |
Contributor
There was a problem hiding this comment.
Suggested change
| Tentez '{ $exec } --help' pour plus d'informations. |
cakebaker
reviewed
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Is it the expected behavior that only two of the tests, those ending with name_once, fail when I run them without applying your other changes?
cakebaker
reviewed
Jul 22, 2026
Comment on lines
+1382
to
+1384
| // The VERSION_CONTROL variable selects the backup type when the command line | ||
| // does not. These run the real binary so the variable is set on the child | ||
| // process, which is the only safe way to test it. |
Contributor
There was a problem hiding this comment.
I don't understand what the second sentence is trying to say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.