sort: avoid reopening non-seekable inputs#13494
Open
wtcpython wants to merge 1 commit into
Open
Conversation
Contributor
|
FIFO is not stdin only. Also we should detect them as error of 1st seek instead of using stat. |
|
GNU testsuite comparison: |
wtcpython
force-pushed
the
sort-fifo-unterminated-line
branch
from
July 22, 2026 02:16
195eb27 to
c95dab0
Compare
wtcpython
changed the title
oech3
reviewed
Jul 22, 2026
| for file in &files { | ||
| open(file)?; | ||
| // Keep the first non-seekable input open so that validation does not consume it before it is | ||
| // read. |
Contributor
There was a problem hiding this comment.
How about keep opening everything without checking FIFO?
wtcpython
force-pushed
the
sort-fifo-unterminated-line
branch
from
July 22, 2026 03:27
c95dab0 to
88c1a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13172.
sortpre-opened every input to validate it before opening it again for processing. For a non-seekable input, the validation open could consume the only writer connection; the subsequent open then waited indefinitely for another writer.When the first seek identifies a non-seekable input, keep that reader open and use it for processing instead of detecting FIFO inputs with metadata. Add a regression test covering an unterminated named FIFO input.