Skip to content

dircolors: turn integration test into unit tests#12507

Open
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:dircolors_unit_tests
Open

dircolors: turn integration test into unit tests#12507
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:dircolors_unit_tests

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

This PR turns an integration test into three unit tests, allowing us to make the StrUtils trait private.

There is another integration test that isn't an integration test. To keep this PR small, I left it for a future PR as it also should integrate changes from #12228

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented May 28, 2026

I don't see any confliction with the linked PR. Am I missing something?

@cakebaker
Copy link
Copy Markdown
Contributor Author

cakebaker commented May 28, 2026

@oech3 there isn't a conflict with the linked PR. I linked to it because it modifies test_shell_syntax() which is the other integration test that should be a unit test.

And while I think your motivation in the linked PR is to remove the unsafe code, there is also a testing aspect to your changes, and thus it probably makes sense to combine the changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented May 28, 2026

I don't understand how you want to combile it currently. Would you cherry-pick the PR when it happens and close it?

@cakebaker cakebaker force-pushed the dircolors_unit_tests branch from d5db03a to bae60b2 Compare June 2, 2026 09:53
@cakebaker
Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • rebased and fixed conflicts in both files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants