feat: nest join ON conditions as Query objects - #20
Merged
Conversation
Keep the simple leftJoin(table, left, right, op, alias) triple, and accept an array of Query::on() / filter queries so extra ON predicates stay on the join instead of falling through to WHERE.
📊 Coverage
Full per-file breakdown in the job summary. |
Contributor
Greptile SummaryThe PR adds Query-based nested JOIN conditions with serialization, SQL compilation, AST conversion, predicate validation, and alias qualification.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "fix: qualify nested join ON columns in A..." | Re-trigger Greptile |
3 tasks
SQL compileFilter accepted search/regex/exists on nested JOIN ON while toAst() silently rewrote them to Raw, so build() and toAst() disagreed.
Member
Author
|
@greptileai review |
SQL compilation prefixes unqualified Query::on operands with the base-table alias when joins are present; toAst() now applies the same qualification so AST consumers resolve the same JOIN columns.
Member
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query::on($left, $right, $op = '=')for column-to-column join ON conditions.join/leftJoin/rightJoin/fullOuterJoinso the second or third argument can be an array of ON queries:leftJoin('orders', '$id', 'customerId', '=', 'ord')leftJoin('orders', [Query::on('$id', 'customerId'), Query::equal('ord.status', ['paid'])])leftJoin('orders', 'ord', [Query::on('$id', 'customerId'), Query::equal('ord.status', ['paid'])])Wire format
{ "method": "leftJoin", "attribute": "orders", "values": [ "ord", {"method": "on", "values": ["$id", "=", "customerId"]}, {"method": "equal", "attribute": "ord.status", "values": ["paid"]} ] }Simple triples are unchanged.
Test plan
composer test(one unrelated xdebug nesting flake in ParserTest)composer lint/composer check