fix(cache): preserve empty nested JSON objects (DAT-2310) - #125
Merged
Conversation
Contributor
Greptile SummaryThe PR preserves empty JSON objects as
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness or security failures identified. The new decoder preserves only the intended empty-object distinction, continues converting valid envelopes and non-empty JSON objects to associative arrays, forwards decoding flags, and retains existing malformed-envelope behavior across each integrated adapter. Important Files Changed
Reviews (1): Last reviewed commit: "(fix): preserve empty objects in JSON-ba..." | Re-trigger Greptile |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Seen red
On current main, the new Redis envelope regression returned empty arrays in place of every empty object:
Verification
The repository Redis Cluster image is amd64-only and its healthcheck segfaults under local arm64 emulation, so the exact fidelity case was also run against a native six-node Redis 7 cluster. The complete local multiplexing E2E process still hits an unrelated existing Swoole segmentation fault; the new multiplexing regression itself passes independently.
Release chain
This is the cache layer of DAT-2310. A stable cache 4.0.x release is required before database, server-ce, and Cloud lock updates; no temporary VCS pin is introduced.
Related: utopia-php/mongo#48, #123.