Fix empty split database metadata reports#197
Conversation
Greptile SummaryTreats a missing split-DB metadata collection as an empty result rather than a fatal error during Appwrite database-source reports, fixing Cloud Backups E2E failures for DocumentsDB archives where the indexes table may not exist.
Confidence Score: 4/5Safe to merge for the reporting path; the silent-empty behaviour in The fix is narrowly scoped and correctly typed — it only intercepts src/Migration/Sources/Appwrite/Reader/Database.php — specifically the Important Files Changed
Reviews (3): Last reviewed commit: "fix: handle empty split database metadat..." | Re-trigger Greptile |
2d7ec53 to
312dfe2
Compare
312dfe2 to
b5100cd
Compare
Pull request was closed
What\n- Treat missing split database metadata collections as empty during Appwrite database-source reports.\n- Add regressions for DocumentsDB reports with no collection metadata table and no indexes metadata table.\n\n## Why\nCloud Backups E2E for DocumentsDB archive reports can request the index resource even when the source collection has no indexes. With DB 6 / split DocumentsDB metadata, counting a missing indexes collection throws
Collection not foundand leaves the archive pending.\n\n## Validation\n-vendor/bin/phpunit --configuration phpunit.xml tests/Migration/Unit/Sources/AppwriteDatabaseReaderTest.php\n-composer lint\n-composer check\n-docker compose exec tests php vendor/bin/phpunit