Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN composer install \
--no-scripts \
--prefer-dist

FROM php:8.3.11-cli-alpine3.20
FROM php:8.4-cli-alpine

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The image tag was previously pinned to a specific Alpine patch release (php:8.3.11-cli-alpine3.20). The new tag php:8.4-cli-alpine is a floating tag: the next docker pull will silently pick up a new Alpine minor version, which can introduce different library versions or behaviour and break reproducible builds.

Suggested change
FROM php:8.4-cli-alpine
FROM php:8.4-cli-alpine3.21

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


WORKDIR /usr/local/src/

Expand Down
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,22 @@
}
},
"require": {
"php": ">=8.1.0",
"php": ">=8.4",
"ext-curl": "*",
"ext-openssl": "*",
"phpmailer/phpmailer": "6.9.1",
"giggsey/libphonenumber-for-php-lite": "9.0.23",
"utopia-php/client": "^0.1.3",
"utopia-php/telemetry": "^0.4"
},
"require-dev": {
"phpunit/phpunit": "11.*",
"laravel/pint": "1.*",
"phpstan/phpstan": "1.*"
"phpstan/phpstan": "^2.0"
},
"config": {
"platform": {
"php": "8.3"
"php": "8.4"
},
"allow-plugins": {
"php-http/discovery": true,
Expand Down
176 changes: 168 additions & 8 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading