Skip to content

Sentry split type and value #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fogelito wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sentry split type and value #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Logger/Adapter/Sentry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ public function push(Log $log): int
'exception' => [
'values' => [
[
'type' => $log->getMessage(),
'type' => $log->getTags()['verboseType'] ?? 'Exception',

@greptile-apps greptile-apps Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Undocumented verboseType tag convention

The verboseType key is only referenced here — it is never set anywhere else in this repository. Callers who do not explicitly add a verboseType tag will silently fall back to the generic 'Exception' type for every exception in Sentry, losing all class-name granularity. There is no doc-comment, constant, or Log method that signals this expectation to callers.

'value' => $log->getMessage(),
'stacktrace' => [
'frames' => $stackFrames,
],
Expand Down
Loading