-
Notifications
You must be signed in to change notification settings - Fork 36
Normalize array-valued Swoole request headers #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?php | ||
|
|
||
| namespace Utopia\Http\Tests; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Utopia\Http\Adapter\Swoole\Request; | ||
|
|
||
| class SwooleRequestTest extends TestCase | ||
| { | ||
| private ?Request $request = null; | ||
|
|
||
| public function setUp(): void | ||
| { | ||
| if (!class_exists(\Swoole\Http\Request::class)) { | ||
| $this->markTestSkipped('The Swoole extension is required for this test.'); | ||
| } | ||
|
|
||
| /** @var \Swoole\Http\Request $swooleRequest */ | ||
| $swooleRequest = new \Swoole\Http\Request(); | ||
| $swooleRequest->header = []; | ||
|
|
||
| $this->request = new Request($swooleRequest); | ||
| } | ||
|
|
||
| public function tearDown(): void | ||
| { | ||
| $this->request = null; | ||
| } | ||
|
|
||
| public function testCanGetScalarHeaders(): void | ||
| { | ||
| $this->request?->getSwooleRequest()->header = [ | ||
| 'x-replaced-path' => '/gateway', | ||
| ]; | ||
|
|
||
| $this->assertEquals('/gateway', $this->request?->getHeader('x-replaced-path')); | ||
| } | ||
|
|
||
| public function testCanNormalizeArrayHeaders(): void | ||
| { | ||
| $this->request?->getSwooleRequest()->header = [ | ||
| 'x-replaced-path' => ['/client', '/gateway'], | ||
| ]; | ||
|
|
||
| $this->assertEquals('/gateway', $this->request?->getHeader('x-replaced-path')); | ||
| } | ||
|
Comment on lines
+30
to
+46
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new tests cover scalar and array values, but two additional cases are worth adding:
Without the case-insensitive test, the new |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loop accesses
$value[$i]where$icounts down fromcount($value)-1. If Swoole ever returns an associative (non-sequential) array for a multi-valued header, these accesses will produceUndefined array keywarnings in PHP 8 and returnnull, causing the loop to silently fall through to$default. Usingarray_values()to re-index first makes this robust: