feat: adapt audit schema to query-lib Attribute and Index VOs - #133
Open
abnegate wants to merge 9 commits into
Open
feat: adapt audit schema to query-lib Attribute and Index VOs#133abnegate wants to merge 9 commits into
abnegate wants to merge 9 commits into
Conversation
Needed so Appwrite can take main's queue 1.3 pin.
Take main's validators ^0.5 pin and refresh database feat-query-lib so Attribute/Index/ColumnType stay current.
ClickHouse was mutating parent Attribute/Index instances in place. MariaDB tests were also losing event=delete rows because persistent PDO plus a new adapter per PHPUnit setUp rolled back uncommitted writes.
|
Thanks for contributing! This repository is a read-only mirror; development for this library happens in |
Member
Author
|
@greptile-apps review |
Greptile SummaryThe PR migrates audit schemas and query handling to the typed value objects and method enums provided by the updated Utopia database/query libraries.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Reviews (7): Last reviewed commit: "(chore): allow utopia-php/query 0.5" | Re-trigger Greptile |
Schema definitions with a known column or index type now use Attribute::string() / Index::key() instead of the generic constructors plus ColumnType / IndexType.
Asterisk wildcards on utopia-php packages are replaced with equivalent caret constraints so Composer ranges stay consistent.
Keep composer.json and composer.lock in sync so `composer validate` passes, and pin utopia-php/database to the current query-lib HEAD.
Member
Author
|
@greptileai review |
This was referenced Aug 21, 2026
Member
Author
|
@greptile-apps review Force re-review of HEAD |
Database::createCollection no longer accepts a string id.
Database feat-query-lib now requires query ^0.5 after nested joins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by appwrite/appwrite#11649 and appwrite-labs/cloud#5410. Depends on utopia-php/database#823.
Why this approach
Database::createCollection()takes aCollectiononly. Audit setup now passesnew Collection(id:, attributes:, indexes:)built from typed Attribute/Index factories.Composer pins
utopia-php/databasetodev-feat-query-lib as 7.0.0(808f90bf).Verified
Not verified
d552413after the Collection-only wrap