Skip to content

fix[frontend](broadcast): removed null arrays access with .length #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSanchez-bit merged 1 commit into from
Aug 13, 2026
Merged

fix[frontend](broadcast): removed null arrays access with .length #2461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/src/features/platform-broadcast/services/broadcast-http.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,17 @@ function withSelector<T extends object>(selector: BulkSelector, resource: T) {
return { selector, ...resource }
}

// Go's nil slices marshal to JSON null; normalize so consumers can safely read `.length`.
function normalize(r: BulkResult | null | undefined): BulkResult {
return { succeeded: r?.succeeded ?? [], failed: r?.failed ?? [] }
}

async function post<Resource extends object>(
path: string,
selector: BulkSelector,
resource: Resource,
): Promise<BulkResult> {
return api.post<BulkResult>(path, withSelector(selector, resource))
return normalize(await api.post<BulkResult>(path, withSelector(selector, resource)))
}

/** Send `resource` to every selected tenant against `path` (a full `/platform/**\/bulk/**` route). */
Expand Down Expand Up @@ -108,5 +113,5 @@ export async function broadcastBrandingAsset(
const form = new FormData()
form.append('file', file)
form.append('selector', JSON.stringify(selector))
return api.post<BulkResult>(BULK_PATHS.branding.uploadAsset(slot), form)
return normalize(await api.post<BulkResult>(BULK_PATHS.branding.uploadAsset(slot), form))
}
Loading