refactor(sonicwall): revamp filter and correlation rules - #2443
Merged
Conversation
Rebuild the SonicWall filter so the parsed events use clear, human-readable field names and match the fields their correlation rules actually consume. Refresh the seven remaining rules so they fire on the real fields the filter emits, and drop three rules that no longer made sense as security signals for this integration. Filter changes (filters/sonicwall/sonic_wall.yml): - Emit clean origin.ip / target.ip (no port or interface glued on) - Emit protocol as tcp/udp only, keep the service hint separately - Emit action / actionResult without leftover quotes - Rescue the full text of quoted fields (message, note, category, rule, session type, VPN policy, user, uuid, action, appName, device time) so they are no longer truncated at the first space - Rename cryptic vendor tokens (m, n, sn, sess, usr, gcat, pri, dpi, ipscat, cs6, ...) to self-explanatory names like log.eventCode, log.deviceSerial, log.sessionType, log.groupCategory - Keep both syslog KV and syslog CEF supported Rules changes (rules/sonicwall/sonicwall_firewall/): - Refresh 7 rules to use the new field names - Remove 3 rules that did not belong to this integration or fired on benign traffic (Capture Client, Encrypted Threats, Zero-Day) Validated against live traffic on env 10.11.11.129.
❌ Go dependencies check failedThere are outdated Go dependencies, or modules that could not be inspected. Script output |
✅ AI review — ApprovedNo issues detected in this diff. ✅
|
![utmstackprapprover[bot]](https://avatars.githubusercontent.com/u/144401876?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Rebuild the SonicWall filter so the parsed events use clear, human-readable field names and match the fields their correlation rules actually consume. Refresh the seven remaining rules so they fire on the real fields the filter emits, and drop three rules that no longer made sense as security signals for this integration.
Why
The filter was producing fields that the correlation rules could not
match, so the SonicWall integration had generated zero alerts. Cryptic field names also made the data hard to work with in dashboards and investigations. This change brings the filter output in line with the rules and with what an analyst expects to see.
Related issue
N/A