Skip to content

fix[backend](socai): sending custom error messages to socai to avoid … - #2374

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_socai_error_handling
Jul 23, 2026
Merged

fix[backend](socai): sending custom error messages to socai to avoid …#2374
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_socai_error_handling

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

architecture (gemini-3-flash-lite) — clean

Summary: Improved error handling and security sanitization for SOC AI upstream responses; no architectural deviations.

No findings.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Missing import of 'fmt' in socai.go causes compilation failure; logic improvements are otherwise sound.

  • high backend/modules/socai/handler/socai.go:64 — The variable 'ctx' is used in the error log string, but 'fmt' is not imported, and 'ctx' is a string variable defined in the scope. While this compiles if 'ctx' is a string, the previous code used 'fmt.Sprintf'. If 'ctx' is not a string, this will fail. More importantly, the 'fmt' package is missing from the imports, which will cause a compilation error.

security (gemini-3-flash-lite) — clean

Summary: Refactored error handling in SOC AI handlers to prevent information disclosure and improve observability.

No findings.

🟢 go-deps — up to date

No pending Go dependency updates.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

ctx is a constant string defined in that same function, no type error expected making ctx +"..."

@AlexSanchez-bit
AlexSanchez-bit merged commit 2f8314f into release/v12.0.0 Jul 23, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_socai_error_handling branch July 23, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant