Skip to content

Extract path config-based classpath computation - #2847

Merged
DavyLandman merged 3 commits into
mainfrom
fix/extract-classpath-computation
Aug 18, 2026
Merged

Extract path config-based classpath computation#2847
DavyLandman merged 3 commits into
mainfrom
fix/extract-classpath-computation

Conversation

@toinehartman

Copy link
Copy Markdown
Member

Extract/unify computation of a class path given a path config.

This code can also be used to simplify class path computations in the following PRs:

@toinehartman toinehartman self-assigned this Aug 17, 2026
Comment thread src/org/rascalmpl/tutor/lang/rascal/tutor/repl/TutorCommandExecutor.java Outdated
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (93c9482) to head (40364f8).

Files with missing lines Patch % Lines
src/org/rascalmpl/shell/ShellEvaluatorFactory.java 85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2847   +/-   ##
=======================================
  Coverage       45%     46%           
- Complexity    6751    6758    +7     
=======================================
  Files          841     841           
  Lines        67062   67066    +4     
  Branches     10021   10021           
=======================================
+ Hits         30847   30865   +18     
+ Misses       33839   33829   -10     
+ Partials      2376    2372    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@toinehartman toinehartman changed the title Unify path config-based classpath computations Extract path config-based classpath computation Aug 17, 2026
Comment thread src/org/rascalmpl/library/util/PathConfig.java Outdated
@toinehartman
toinehartman force-pushed the fix/extract-classpath-computation branch from f59ef86 to a57cc67 Compare August 18, 2026 11:30
@toinehartman
toinehartman removed the request for review from DavyLandman August 18, 2026 12:04
@DavyLandman
DavyLandman force-pushed the fix/extract-classpath-computation branch from a57cc67 to 40364f8 Compare August 18, 2026 13:15
@sonarqubecloud

Copy link
Copy Markdown

@DavyLandman
DavyLandman merged commit dc40443 into main Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants