fix/double src resolutions#2772
Draft
jurgenvinju wants to merge 3 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6722 6718 -4
=======================================
Files 794 794
Lines 65936 65936
Branches 9888 9888
=======================================
+ Hits 30764 30766 +2
+ Misses 32792 32789 -3
- Partials 2380 2381 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Running this PR with |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The final bootstrap of removing Tree@\loc led to these errors while checking the final compilation of the compiler:
These errors are from the log https://github.com/usethesource/rascal-core-big-tests/actions/runs/25805901058 and not consecutively:
We focus first on the last three issues where:
someBase.someField.srcis now leading to the "Base expression of field selection is ambiguous and should be resolved" error,<base>.someField@\locdid not.someBase.someFieldis the base we are talking about in this error message, or justsomeBase.