[POM-leading for DSLs] Routing to dedicated remote language servers#1069
Open
toinehartman wants to merge 85 commits into
Open
Conversation
…ing-for-dsls-redo
toinehartman
changed the base branch from
main
to
feature/1010-pom-leading-for-dsls/final
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
b434ff4 to
6f475fe
Compare
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
600df56 to
3ed29d4
Compare
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
3ed29d4 to
2b01979
Compare
toinehartman
commented
May 12, 2026
| , "-cp", classPath | ||
| , "org.rascalmpl.vscode.lsp.parametric.ParametricLanguageServer" | ||
| , "--exitWhenEmpty" | ||
| // , new GsonBuilder().create().toJson(lang, LanguageParameter.class).replace("\"", "\\\"") // escape JSON string on command line |
Member
Author
There was a problem hiding this comment.
It would be nice you use the dedicated language feature of the parametric LSP here, but then we should also probably swallow the registerLanguage call that triggered this, as otherwise, we are registering twice and wasting resources.
DavyLandman
requested changes
May 13, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
I think this is heading in the right direction. But it's not ready yet.
| private final Map<String, String> languagesByExtension = new ConcurrentHashMap<>(); | ||
| // NOTE | ||
| // 1. This map should only contains running server processes. | ||
| // 2. Upon removal from this map, the process should be killed to avoid resource leaks. |
Member
There was a problem hiding this comment.
we should also register a shutdown hook to always close our child processes.
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
7ff9ea8 to
7e04b27
Compare
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
7e04b27 to
754297e
Compare
toinehartman
force-pushed
the
feature/1010-pom-leading-for-dsls/remote-routing
branch
from
e44a9fe to
9ce67cd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first of a series. gradually implementing POM-leading behavior in DSLs/the parametric server.
This PR introduces a routing language server, which delegates incoming LSP requests to the appropriate parametric language server, dedicated to a single language. A dedicated server is started upon initial language registration.
Closes #1076