fix(runtime): wait for Caido readiness by deadline - #1053
Draft
maxi-maxima wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STRIX_CAIDO_BOOT_WAIT_Swith a 300-second default for slower container hostsRoot cause
Caido readiness was bounded by an attempt count rather than elapsed time. The existing backoff exhausted its ten attempts after roughly 68–73 seconds, so a healthy but slow cold start on a loaded or hosted runner could be reported as a permanent bootstrap failure.
Impact
Slow runners now get a bounded, configurable readiness window while fast failures still stop at the deadline with the elapsed budget and attempt count in the error.
Validation
uv run pytest tests/test_caido_bootstrap.py tests/test_config_loader.py -q -k "not test_persist_current_sets_0600_mode"— 20 passed, 1 Windows-only mode assertion deselecteduv run ruff format --check .— passeduv run ruff check .— passedmypy,pyright, andbanditchecks for the changed runtime/configuration paths — passedFixes #1036.
Related to #1037.