Skip to content

denied retry fallback - #1041

Open
bearsyankees wants to merge 7 commits into
mainfrom
devin/1786367820-denied-retry-fallback
Open

denied retry fallback#1041
bearsyankees wants to merge 7 commits into
mainfrom
devin/1786367820-denied-retry-fallback

Conversation

@bearsyankees

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds configurable retry and pinning behavior that replays content-denied turns on a compatible fallback model.

  • Adds fallback-model and denial-threshold settings with documentation.
  • Validates provider-family and tool-schema compatibility before starting a scan.
  • Derives fallback-specific model settings and persists per-agent denial state across snapshots.
  • Adds coverage for retries, pinning, fallback settings, and snapshot restoration.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported provider, tool-schema, and model-settings incompatibilities are now guarded or configured independently for the fallback.

Important Files Changed

Filename Overview
strix/config/models.py Adds compatibility validation that rejects fallback models requiring a different provider credential path or tool schema.
strix/config/settings.py Adds validated environment-backed settings for the fallback model and per-agent denial threshold.
strix/core/agents.py Tracks, snapshots, and restores per-agent denial counts and permanent fallback state.
strix/core/execution.py Replays denied turns using fallback-specific model configuration and pins agents after the configured threshold.
strix/core/runner.py Validates fallback compatibility and configures independently derived fallback model settings during scan setup.
tests/test_denied_retry_fallback.py Covers fallback replay, threshold pinning, disabled behavior, model settings, and snapshot restoration.

Reviews (6): Last reviewed commit: "fix: also reject a fallback model from a..." | Re-trigger Greptile

Comment thread strix/core/execution.py
@devin-ai-integration

Copy link
Copy Markdown
Contributor

@greptile

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@greptile

Comment thread strix/core/runner.py
@devin-ai-integration

Copy link
Copy Markdown
Contributor

@greptile

1 similar comment
@devin-ai-integration

Copy link
Copy Markdown
Contributor

@greptile

Comment thread strix/core/runner.py Outdated
@devin-ai-integration

Copy link
Copy Markdown
Contributor

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant