fix core: use peer address for websocket client connections#1276
Open
seriouscoder43 wants to merge 1 commit into
Open
fix core: use peer address for websocket client connections#1276seriouscoder43 wants to merge 1 commit into
seriouscoder43 wants to merge 1 commit into
Conversation
apolukhin
requested changes
Jun 30, 2026
| async def test_client(service_client, service_port, test_name): | ||
| response = await service_client.get( | ||
| '/test-client', | ||
| params={'test': test_name, 'port': service_port}, |
Member
There was a problem hiding this comment.
But the service_port is the port of the server that is written in userver. It makes the remote_port == port ? "OK" check wrong
Contributor
Author
There was a problem hiding this comment.
No. For websockets tests the service connects a client to the server_port it also owns. test_client only initiates that run here. Do you want me to write a separate test case instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeWebsocketConnection() incorrectly uses Getsockname() to save the remote peer. Then connection's RemoteAddr() becomes always wrong