Skip to content

🧪 Add C# Sphinx integration test#78

Merged
ubmarco merged 6 commits into
useblocks:mainfrom
arnoox:issue/77-csharp-integration-test
Jun 19, 2026
Merged

🧪 Add C# Sphinx integration test#78
ubmarco merged 6 commits into
useblocks:mainfrom
arnoox:issue/77-csharp-integration-test

Conversation

@arnoox

@arnoox arnoox commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Closes #77

Summary

C# language support was already fully implemented in the codebase (parser, tree-sitter dependency, scope detection, unit tests, documentation). This PR adds the missing Sphinx integration test to satisfy the last acceptance criterion.

Changes

  • tests/doc_test/cs_basic/ — minimal Sphinx project with a .cs source file containing a one-line annotation
  • tests/test_src_trace.py — new parametrized case for the cs_basic project in test_build_html
  • tests/__snapshots__/test_src_trace/ — generated snapshot asserting IMPL_1 need is emitted from the C# source

Acceptance criteria

  • C# parser / comment extractor added to sphinx-codelinks (pre-existing)
  • Unit tests covering C# comment annotation parsing (pre-existing)
  • Documentation updated to list C# as a supported language (pre-existing)
  • Integration test with a minimal C# project ✅ added in this PR

@arnoox

arnoox commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author
  • Seems like .. feature:: C# Language Support is missing in features.rst?
  • The changelog needs to be updated.

Add the missing "C# Language Support" entry to features.rst (the
parser was already implemented but never documented) and note the
new C# integration test and docs update in the changelog.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@arnoox

arnoox commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

Pushed fixes for both findings:

  • Added the missing C# Language Support .. feature:: entry to features.rst (parser was implemented but never documented — it now matches the format of the C/C++/Python/YAML/Rust entries, with FE_CSHARP, FAULT_CSHARP_1, FAULT_CSHARP_2).
  • Added changelog entries under "Upcoming" for the docs update and the new C# integration test.

Re the doctree.xml snapshot file: replied inline — it's the generated syrupy snapshot for the new cs_basic test case and is required, not stray.

Verified tox -e docs-update (-nW --keep-going) builds clean with the new feature/fault IDs, and tox -e py312-sphinx8-needs5 -- tests/test_src_trace.py passes with all 5 snapshots.

@arnoox arnoox requested a review from patdhlk June 17, 2026 07:33
@ubmarco ubmarco self-requested a review June 19, 2026 15:48
@ubmarco ubmarco merged commit a76f8fd into useblocks:main Jun 19, 2026
12 checks passed
@ubmarco ubmarco mentioned this pull request Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add C# language support

2 participants