Pin the unsloth-sd-prebuilt actions to commit SHAs - #12
Merged
Conversation
All 18 action references in unsloth-sd-prebuilt.yml resolved through a moving tag, including msvc-dev-cmd and cuda-toolkit, which run in the jobs that build and upload the prebuilt binaries. Each SHA is the commit the corresponding tag points at today, so nothing about what runs changes and no version is bumped. That includes the older majors this workflow pins deliberately, checkout v4, upload-artifact v4, download-artifact v4, setup-python v5 and cuda-toolkit v0.2.22, none of which are moved forward here. Upstream build.yml, close-inactive-issues.yml and stale-prs.yml are left alone so this costs nothing at the next upstream sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as unslothai/llama.cpp#105 (merged) and unslothai/whisper.cpp#25. Scoped to
unsloth-sd-prebuilt.yml, the only unsloth-owned workflow here: 1/19 pinned, now 19/19.ilammy/msvc-dev-cmd0b201ecJimver/cuda-toolkit95b5a29actions/checkout11d5960actions/upload-artifactea165f8actions/download-artifactd3f86a1actions/setup-pythona26af69actions/cache/save55cc834Why this cannot change behaviour
Every SHA is the commit its tag points at right now, so identical code runs before and after. Note this workflow deliberately sits on older majors than our other repos (
checkout@v4,setup-python@v5,cuda-toolkit@v0.2.22). Those are pinned where they are, not moved forward — this PR is not a version bump and does not pull in the v6/v7 breaking changes.Verified before pushing:
git diffis 18 insertions / 18 deletions in one file, and every changed line is auses:line.action.ymlpresent, includingsave/action.ymlfor theactions/cache/savesubaction.actionlintreports nothing new.Deliberately not touched
Upstream
build.yml(50 refs),close-inactive-issues.ymlandstale-prs.ymlare left unpinned so this costs nothing at the next upstream sync. That is why the repo total is 19/71 rather than 71/71. Worth noting separately that upstreambuild.ymlstill usesactions/checkout@v3, which actionlint flags as too old to run on GitHub Actions, and declares an unknownartifact-metadatapermission scope. Both are upstream problems, not ours to fix here.