Prebuilt: pin the IQ1_XS, IQ1_XXS and IQ1_XXXS quant types onto master - #93
Merged
Conversation
#92 merged into its stacked base branch rather than master, so the pin landed on prset-drop-merged-26841 and never reached the file the nightly reads. Same one-line addition, on top of master. #91 is merged now, into iq1-narrow-upstream-base rather than master, so the tree resolve builds still does not contain it and the pin is still what puts it in. A merged required pin keeps being mixed in, with a warning, which is the intended path here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#92 was merged into its stacked base branch
prset-drop-merged-26841rather than into master, so the pin commit is sitting on that branch and never reached thescripts/unsloth/pr-set.jsonthe nightly actually reads. Master today has only the #90 change:This is the same one-line addition from #92, reapplied on top of master. Opened as a fresh branch rather than retargeting
prset-drop-merged-26841, because that branch carries its own copy of the #90 commit and master took #90 as a squash, so pointing it at master would put a duplicate of #90 into the diff.The pin still works now that #91 is merged
#91 merged into
iq1-narrow-upstream-base, not into master, so the treeresolvebuilds (upstream base tag plus pins) still does not contain the change. The pin is what puts it there.The gate handles this: a required pin that is no longer open keeps being merged in and logs a warning, which is exactly the case the
_docdescribes. The membership check also still passes,c86ed269is a commit of #91. Once a base tag ever contains this work the entry should be deleted outright rather than left to no-op, per the note added in #90.Verification
Unchanged from #92, since the pinned commit and the rest of the set are the same. Resolve replay on
b10356givesMERGED OKat tagb10356-mix-1c79028, with only #70 needingadditive_merge.pyand only for pure add/add hunks. The tree that comes out hashes tocdc8f9490e4e33bc0dc87c94842455f6a8e5e189, which is the tree that was built and tested:sm_100build completes cleantest-backend-ops -o MUL_MAT -b CUDA01219/1219,-o MUL_MAT_ID874/874test-backend-opsitself hitting the 1500s ctest timeout