fix(docker): do not delete the shared fallback icon when removing an icon-less container

[Junker der Provinz (junkerderprovinz)]

Fixes #2691.

removeContainer() unlinks $docroot.$info[$name]['icon']. For a container whose template has no icon, that recorded path is the shared fallback /plugins/dynamix.docker.manager/images/question.png (set when the icon is empty), so removing or updating such a container deletes question.png for the whole system until the next reboot re-extracts bzroot.

Per-container cached icons live under images-ram ($dockerManPaths['images-ram']); the shared fallback does not. This guards the cleanup so it only unlinks icons inside the images-ram cache and never the shared static file. Containers with a real icon are cleaned up exactly as before.

[coderabbitai]

Warning

Review limit reached

@junkerderprovinz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 549ea3ca-30fa-4cca-a094-041356d34e60

📥 Commits

Reviewing files that changed from the base of the PR and between 6d8c2cd and 973fe4e.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix.docker.manager/include/DockerClient.php

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}