Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
WalkthroughThis PR updates localization strings across 24 language locale files. It adds onboarding status messaging when no valid license device is detected and replaces server error messaging that previously described boot device access failures with new messaging focused on missing TPM or USB flash license devices. ChangesLicense Device Localization Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0897e47244
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "server.state.enoflash.heading": "Обнаружено недопустимое устройство лицензии", | ||
| "server.state.enoflash.humanReadable": "Устройство лицензии", |
There was a problem hiding this comment.
The new Russian copy for this enoflash state flips the meaning of the error: it says an invalid license device was found, while this key is used for the "no valid license device detected" condition. In the same block, humanReadable was reduced to just "Устройство лицензии" (without "Нет"), so users in this error path will get misleading status text instead of a clear missing-device message.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/src/locales/cs.json`:
- Line 349: The Czech string for key
"onboarding.licenseStep.status.noLicenseDevice" (and the duplicate at the other
occurrence) uses incorrect gender agreement; update both values to use neuter
agreement by replacing the current text with "Nebylo zjištěno žádné platné
licenční zařízení" so the noun zařízení agrees grammatically.
In `@web/src/locales/fr.json`:
- Around line 782-784: The French message for key
"server.state.enoflash.message" contains a non-French token "सक्रियेज"; update
that value to use correct French wording (e.g., replace "सक्रियेज la licence"
with "activez la licence") so the string reads properly in French and UI
rendering won't break.
In `@web/src/locales/ru.json`:
- Line 349: The Russian string for the key
onboarding.licenseStep.status.noLicenseDevice (and the duplicate entries around
lines referenced) incorrectly says “an invalid license device was detected”;
update the translation for onboarding.licenseStep.status.noLicenseDevice and the
matching keys at the other occurrences so the wording clearly states “no valid
license device detected” (e.g., use a phrase like «Действительное устройство
лицензии не обнаружено» or similar consistent Russian copy) to match the actual
state.
In `@web/src/locales/uk.json`:
- Line 349: The Ukrainian phrasing for the license-device messages is awkward;
update the value of "onboarding.licenseStep.status.noLicenseDevice" to use the
idiomatic noun phrase "ліцензійного пристрою" and correct case agreement—e.g.
replace the current string with "Не виявлено дійсного ліцензійного пристрою";
apply the same phrasing/case fix to the related keys around lines 782-784 so all
user-facing messages consistently use "ліцензійного пристрою" and proper
Ukrainian grammar.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 6894e538-cc17-461b-a36c-dac4c418439d
📒 Files selected for processing (24)
web/src/locales/ar.jsonweb/src/locales/bn.jsonweb/src/locales/ca.jsonweb/src/locales/cs.jsonweb/src/locales/da.jsonweb/src/locales/de.jsonweb/src/locales/es.jsonweb/src/locales/fr.jsonweb/src/locales/hi.jsonweb/src/locales/hr.jsonweb/src/locales/hu.jsonweb/src/locales/it.jsonweb/src/locales/ja.jsonweb/src/locales/ko.jsonweb/src/locales/lv.jsonweb/src/locales/nl.jsonweb/src/locales/no.jsonweb/src/locales/pl.jsonweb/src/locales/pt.jsonweb/src/locales/ro.jsonweb/src/locales/ru.jsonweb/src/locales/sv.jsonweb/src/locales/uk.jsonweb/src/locales/zh.json
| "onboarding.licenseStep.title": "Licence Unraid OS", | ||
| "onboarding.licenseStep.description": "Připraveno k aktivaci. Klikněte níže pro správu vaší licence a registrace serveru v Unraid Account App.", | ||
| "onboarding.licenseStep.status.registered": "Registrováno", | ||
| "onboarding.licenseStep.status.noLicenseDevice": "Nebyl zjištěn žádný platný licenční zařízení", |
There was a problem hiding this comment.
Fix Czech gender agreement in “no valid license device” text.
At Line 349 and Line 782, use neuter agreement for zařízení:
Nebyl zjištěn žádné platné licenční zařízení is grammatically off; prefer wording like Nebylo zjištěno žádné platné licenční zařízení.
Also applies to: 782-782
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/locales/cs.json` at line 349, The Czech string for key
"onboarding.licenseStep.status.noLicenseDevice" (and the duplicate at the other
occurrence) uses incorrect gender agreement; update both values to use neuter
agreement by replacing the current text with "Nebylo zjištěno žádné platné
licenční zařízení" so the noun zařízení agrees grammatically.
| "server.state.enoflash.heading": "Aucun périphérique de licence valide détecté", | ||
| "server.state.enoflash.humanReadable": "Aucun périphérique de licence", | ||
| "server.state.enoflash.message": "<p>Aucun périphérique TPM valide ni clé USB n’a été détecté pour la licence. Connectez une clé USB compatible avec la licence ou सक्रियez la licence TPM, puis actualisez l’enregistrement.</p>", |
There was a problem hiding this comment.
Fix mixed-language token in French error message.
Line 784 contains सक्रियेज, which is not French and will appear broken in UI. Replace it with French wording (e.g., activez).
Suggested patch
- "server.state.enoflash.message": "<p>Aucun périphérique TPM valide ni clé USB n’a été détecté pour la licence. Connectez une clé USB compatible avec la licence ou सक्रियez la licence TPM, puis actualisez l’enregistrement.</p>",
+ "server.state.enoflash.message": "<p>Aucun périphérique TPM valide ni clé USB n’a été détecté pour la licence. Connectez une clé USB compatible avec la licence ou activez la licence TPM, puis actualisez l’enregistrement.</p>",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "server.state.enoflash.heading": "Aucun périphérique de licence valide détecté", | |
| "server.state.enoflash.humanReadable": "Aucun périphérique de licence", | |
| "server.state.enoflash.message": "<p>Aucun périphérique TPM valide ni clé USB n’a été détecté pour la licence. Connectez une clé USB compatible avec la licence ou सक्रियez la licence TPM, puis actualisez l’enregistrement.</p>", | |
| "server.state.enoflash.heading": "Aucun périphérique de licence valide détecté", | |
| "server.state.enoflash.humanReadable": "Aucun périphérique de licence", | |
| "server.state.enoflash.message": "<p>Aucun périphérique TPM valide ni clé USB n'a été détecté pour la licence. Connectez une clé USB compatible avec la licence ou activez la licence TPM, puis actualisez l'enregistrement.</p>", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/locales/fr.json` around lines 782 - 784, The French message for key
"server.state.enoflash.message" contains a non-French token "सक्रियेज"; update
that value to use correct French wording (e.g., replace "सक्रियेज la licence"
with "activez la licence") so the string reads properly in French and UI
rendering won't break.
| "onboarding.licenseStep.title": "Лицензия Unraid OS", | ||
| "onboarding.licenseStep.description": "Готово к активации. Нажмите ниже, чтобы управлять своей лицензией и регистрацией сервера в приложении учетной записи Unraid.", | ||
| "onboarding.licenseStep.status.registered": "Зарегистрировано", | ||
| "onboarding.licenseStep.status.noLicenseDevice": "Обнаружено недопустимое устройство лицензии", |
There was a problem hiding this comment.
Russian copy meaning is inconsistent with the actual state (“no valid device detected”).
Line 349 and Line 782 currently read as “an invalid license device was detected,” but this state is “no valid license device detected” (also reflected by Line 784). Please align the wording so users don’t misread the condition.
Suggested text adjustment
- "onboarding.licenseStep.status.noLicenseDevice": "Обнаружено недопустимое устройство лицензии",
+ "onboarding.licenseStep.status.noLicenseDevice": "Не обнаружено допустимое устройство лицензии",
- "server.state.enoflash.heading": "Обнаружено недопустимое устройство лицензии",
- "server.state.enoflash.humanReadable": "Устройство лицензии",
+ "server.state.enoflash.heading": "Не обнаружено допустимое устройство лицензии",
+ "server.state.enoflash.humanReadable": "Нет устройства лицензии",Also applies to: 782-783
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/locales/ru.json` at line 349, The Russian string for the key
onboarding.licenseStep.status.noLicenseDevice (and the duplicate entries around
lines referenced) incorrectly says “an invalid license device was detected”;
update the translation for onboarding.licenseStep.status.noLicenseDevice and the
matching keys at the other occurrences so the wording clearly states “no valid
license device detected” (e.g., use a phrase like «Действительное устройство
лицензии не обнаружено» or similar consistent Russian copy) to match the actual
state.
| "onboarding.licenseStep.title": "Ліцензія Unraid OS", | ||
| "onboarding.licenseStep.description": "Готові до активації. Натисніть нижче, щоб керувати своєю ліцензією та реєстрацією сервера в застосунку Unraid Account.", | ||
| "onboarding.licenseStep.status.registered": "Зареєстровано", | ||
| "onboarding.licenseStep.status.noLicenseDevice": "Не виявлено дійсного пристрою ліцензії", |
There was a problem hiding this comment.
Polish Ukrainian phrasing for natural, user-facing wording.
Line 349 and Line 782-784 currently use awkward constructions (пристрою ліцензії, не виявлено дійсний ...). Prefer idiomatic forms like ліцензійного пристрою and corrected case agreement.
Suggested text adjustments
- "onboarding.licenseStep.status.noLicenseDevice": "Не виявлено дійсного пристрою ліцензії",
+ "onboarding.licenseStep.status.noLicenseDevice": "Не виявлено дійсного ліцензійного пристрою",
- "server.state.enoflash.heading": "Не виявлено дійсного пристрою ліцензії",
- "server.state.enoflash.humanReadable": "Немає пристрою ліцензії",
- "server.state.enoflash.message": "<p>Для ліцензування не виявлено дійсний TPM або USB флеш-пристрій. Підключіть USB флеш-пристрій, що підтримує ліцензію, або увімкніть ліцензування TPM, а потім оновіть реєстрацію.</p>",
+ "server.state.enoflash.heading": "Не виявлено дійсного ліцензійного пристрою",
+ "server.state.enoflash.humanReadable": "Немає ліцензійного пристрою",
+ "server.state.enoflash.message": "<p>Для ліцензування не виявлено дійсного TPM або USB-флешпристрою. Підключіть USB-флешпристрій, що підтримує ліцензування, або увімкніть ліцензування через TPM, а потім оновіть реєстрацію.</p>",Also applies to: 782-784
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/locales/uk.json` at line 349, The Ukrainian phrasing for the
license-device messages is awkward; update the value of
"onboarding.licenseStep.status.noLicenseDevice" to use the idiomatic noun phrase
"ліцензійного пристрою" and correct case agreement—e.g. replace the current
string with "Не виявлено дійсного ліцензійного пристрою"; apply the same
phrasing/case fix to the related keys around lines 782-784 so all user-facing
messages consistently use "ліцензійного пристрою" and proper Ukrainian grammar.
1 participant
Summary by CodeRabbit