Add InvoiceReceipt template and update rendering modes to replace the hardcoded mode:email#45
Add InvoiceReceipt template and update rendering modes to replace the hardcoded mode:email#45yeabwang wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 31 31
Lines 1937 1937
Branches 382 382
=======================================
Hits 1850 1850
Misses 86 86
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the PR! Overall, the implementation looks good. The project builds successfully, all tests pass, and the invoice renders correctly in the demo using Document mode. I tested the PDF generation workflow shown in the example. When exported as A4, the pagination isn’t clean: the main invoice appears on page 1, the footer moves to a mostly empty page 2, and page 3 is blank. Since the template is described as print-ready, this pagination issue is worth taking a look at. Otherwise, the invoice component and rendering-mode changes look good. |
Summary
Adds a print-ready invoice/receipt template and renders each demo template using its configured mode. Addressing #20
Changes
Test Plan
pnpm buildpassespnpm testpassesNotes
Any additional context for reviewers.