docs: grilling-session foundation — Intent Assessor (ADR-0011), verify:changelog PRD, #161 doc fix#167
Merged
Merged
Conversation
The large-diff guidance in review-pr.md suggested tightening the base branch with `--base feature/x`, but no such flag exists — the base is auto-resolved per ADR-0009 with no per-run override. Replace it with accurate advice (split into smaller branches/PRs) and state that the base cannot be overridden. Closes #161. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…icts Captures the design grilled for issue #160: a dedicated Intent Assessor agent produces live per-AC verdicts (coverage, not quality) against the diff, with a pure overlay-merge helper keeping the skeleton as the structural source of truth. Why: the Intent Check block could only ever render "unaddressed" — the Intent Checker emits a static skeleton and nothing assessed it against the diff. ADR-0011 records why assessment lives in a dedicated agent (over Option A / B1), why "addressed" means coverage, and why the Assessor is excluded from the Spawn Set. CONTEXT.md gains the Intent Assessor term and a reworded Intent Check entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Docs-only PR that lands the design foundation for upcoming unic-pr-review “Intent Assessor” work (ADR + PRD + glossary), adds a release-tools PRD for the verify:changelog nested-plugin gate bug, and fixes review-pr documentation that previously suggested a non-existent --base flag.
Changes:
- Add
unic-pr-reviewADR-0011 (Intent Assessor) and PRD for live Intent Check verdicts; updateCONTEXT.mdglossary accordingly. - Add PRD documenting the
verify:changelognested-plugin version-bump gate bug and proposed fix approach. - Update
review-prlarge-diff guidance to remove the fictional--baseflag and record the fix in the plugin CHANGELOG.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/issues/verify-changelog-nested-plugin-gate/PRD.md | New PRD capturing the nested-plugin verify:changelog gate root cause + solution outline. |
| apps/claude-code/unic-pr-review/docs/issues/unic-pr-review-intent-check-verdicts/PRD.md | New PRD specifying Intent Assessor approach and acceptance criteria. |
| apps/claude-code/unic-pr-review/docs/adr/README.md | Adds ADR-0011 to the plugin ADR index. |
| apps/claude-code/unic-pr-review/docs/adr/0011-intent-assessor-for-live-ac-verdicts.md | New ADR documenting why Intent Assessor exists and how overlay-merge works. |
| apps/claude-code/unic-pr-review/CONTEXT.md | Glossary updates defining Intent Assessor and clarifying Intent Check / Review Aspect. |
| apps/claude-code/unic-pr-review/commands/review-pr.md | Removes bogus --base guidance; clarifies base branch is auto-resolved and suggests splitting large diffs. |
| apps/claude-code/unic-pr-review/CHANGELOG.md | Records the docs fix under “Fixed”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…link The PRD and ADR-0011 both cited 'PRD §10' as the source of the mixed-verdict expectation, but no document with numbered sections (let alone a §10) exists anywhere in the repo, making the cross-reference unresolvable. Point both at the Review Summary mock in issue #160 — the actual canonical source, already cited elsewhere in both files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…convention
The PRD was restructured from numbered sections into named headings, so
every 'PRD §10' / 'PRD §81' reference dangled — the numbers no longer
map to anything. The renderer modules already use the correct convention
('PRD § Schema: Review Summary'). Align the six remaining stragglers
(CHANGELOG, review-pr command, render-summary test, renderer JSDoc,
intent-checker agent, ADR-0006) to named sections so all PRD references
resolve.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documentation and decision artefacts from two grilling sessions (#160 Intent Check, #161 review-pr docs), plus the foundation the Intent Assessor work builds on.
Three commits:
docs(unic-pr-review): add ADR-0011 and PRD for live Intent Check verdicts— ADR-0011 (Intent Assessor as a dedicated agent), the [unic-pr-review] Intent Check verdicts are static (always "unaddressed") #160 PRD, and the CONTEXT.md glossary terms (Intent Assessor; refined Intent Check / Review Aspect). Foundation for slices [unic-pr-review] Intent Check overlay-merge helper #164–166.docs(release-tools): add PRD for verify:changelog nested-plugin gate bug— PRD ([release-tools] verify:changelog version-bump gate never fires for nested plugins #162) for the version-bump gate that silently never fires for nested plugins; tracked for implementation in [release-tools] Make verify:changelog version-bump gate fire for nested plugins #163.docs(unic-pr-review): drop fictional --base flag from review-pr guidance— the [unic-pr-review] review-pr docs suggest a--baseflag that does not exist #161 fix: replaces a--base feature/xsuggestion (no such flag exists) with accurate guidance; base is auto-resolved per ADR-0009.Why
These land the foundation on
developso the Archon rollout of the Intent Assessor chain (#164 → #165 → #166) and the verify:changelog fix (#163) can branch fromdevelopwith ADR-0011, the glossary, and both PRDs already present — without them, agents would work against missing decisions. The #161 doc fix removes a documented-but-nonexistent flag that would mislead users.Docs-only; no runtime code changes.
pnpm ci:checkclean on the changed files.Closes #161.
Refs #160, #162, #163.
🤖 Generated with Claude Code