fix: the delete endpoints for saved requests and mod... in api_server.py#1908
Open
orbisai0security wants to merge 2 commits intounclecode:developfrom
Open
Conversation
docs: update version references to 0.8.6
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
docs/examples/website-to-api/api_server.py.Vulnerability
V-005docs/examples/website-to-api/api_server.py:265Description: The DELETE endpoints for saved requests and models lack authorization checks to verify resource ownership before deletion. Any authenticated user can delete resources belonging to other users by simply providing the resource identifier. The endpoint at line 265 deletes saved requests without validating that the requesting user owns the request, and the endpoint at line 340 deletes models without checking admin privileges. This represents a complete failure of access control on destructive operations.
Changes
docs/examples/website-to-api/api_server.pyVerification
Automated security fix by OrbisAI Security