fix: suppress config deprecation stderr in JSON mode globally (#824)#3198
Merged
Conversation
Add SUPPRESS_CONFIG_WARNINGS_STDERR AtomicBool flag in runtime/config.rs and expose suppress_config_warnings_for_json_mode() via runtime crate. In main.rs, scan raw argv for --output-format json before parse_args and activate the flag so no settings-load warnings reach stderr on any JSON-mode surface (status, sandbox, system-prompt, mcp list, skills list, agents list, --resume /config*, etc.). Text-mode surfaces are unaffected; prose deprecation warnings continue to appear on stderr. All 572+ tests pass (one pre-existing worker_boot failure unrelated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ROADMAP #824.
Root cause:
emit_config_warning_once()inruntime/src/config.rsalways usedeprintln!with no output-format awareness, leakingenabledPlugins is deprecatedto stderr on every JSON-mode surface.Fix: Add
SUPPRESS_CONFIG_WARNINGS_STDERR: AtomicBoolflag. Set it before any settings load when--output-format jsondetected in argv. All JSON-mode surfaces (status,sandbox,system-prompt,mcp list,skills list,agents list,--resume /config*) now exit with empty stderr. Text-mode unchanged.Tests: 572 pass, 1 pre-existing failure unrelated.