fix: route all JSON-mode abort envelopes to stdout (#819 #820 #823)#3197
Merged
Conversation
All handled errors in --output-format json mode now write the structured abort envelope to stdout (rc=1) and keep stderr empty. Previously the top-level error handler and resume_session JSON branches used eprintln! which sent the envelope to stderr, breaking machine consumers that read stdout for command payloads. Surfaces fixed: - Top-level abort handler (main.rs): export --session <missing>, session <subcommand>, prompt (no text), unknown subcommand fallthrough, flag errors, and all other run() failures - resume_session JSON branches: session load errors, unsupported commands, parse errors, command execution errors Test changes: updated 24 failing contract tests to assert JSON envelopes on stdout. Added stderr-clean assertions where appropriate. 70 contract tests pass (was 68; 2 additional from regression coverage). ROADMAP: #819 (export session-not-found), #820 (interactive_only class), #823 (missing prompt)
|
Comprehensive. Covering every code path — top-level handler, resume_session, and all fallthrough surfaces — is exactly what this needed. 70 contract tests is solid confidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ROADMAP #819, #820, #823.
All handled errors in
--output-format jsonmode now write the structured abort envelope to stdout (rc=1) and keep stderr empty. Previously the top-level error handler andresume_sessionJSON branches usedeprintln!which sent the envelope to stderr.Surfaces fixed:
export --session <missing>,session <subcommand>,prompt(no text), unknown subcommand fallthrough, flag errors, and all otherrun()failuresresume_sessionJSON branches: session load errors, unsupported commands, parse errors, command execution errorsTests: Updated 24 failing contract tests to assert JSON envelopes on stdout. 70 contract tests pass (was 68).