Expand fitted temperature range of impurities - #4521
Conversation
… 200 to 600 to accommodate larger datasets. Updated relevant initialisation parameters in `impurity_radiation_variables.py` and `impurity_radiation.py`.
chris-ashe
changed the title
…date documentation
- Introduced `impurity_loss_functions.py` to plot Line and Bremsstrahlung loss function profiles.
- Updated the electron density in plasma radiation documentation from \(10^{19} \text{m}^{-3}\) to \(10^{20} \text{m}^{-3}\).
- Increased the source data points from 200 to 600 and adjusted the fitted temperature range.
f233594 to
24adec2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4521 +/- ##
==========================================
+ Coverage 49.30% 49.32% +0.01%
==========================================
Files 150 150
Lines 29769 29772 +3
==========================================
+ Hits 14679 14685 +6
+ Misses 15090 15087 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…etter visualization
5ffc809 to
a91ba5e
Compare
| @@ -54,7 +54,7 @@ class ImpurityRadiationData: | |||
| ) | |||
|
|
|||
| n_charge_impurity_profile: list[float] = field( | |||
| default_factory=lambda: np.zeros((N_IMPURITIES, 200)) | |||
| default_factory=lambda: np.zeros((N_IMPURITIES, 600)) | |||
There was a problem hiding this comment.
Could we make 600 a constant at the top of this file?
|
Requesting modeller review to confirm changes to unit tests and regression tests are acceptable |
As long as you can confirm you have checked that Lz and are the close to the old values for the old temperature range I don't there will be a problem. I find the high value of Lz for Fe below 1 eV surprising, but since we never use temperatures below 1 eV, and we never use Fe, this is hardly an issue. |
|
@mkovari here is a plot of the old data and new data (only the new data on the old time range). There is very little difference. |
…s function points and update related calculations
4 participants
Description
Updates the loss function data for impurities to comprise of 600 elements from 0.25 eV up to 500 keV
Checklist
I confirm that I have completed the following checks: