Skip to content

Updated PF numbering in outputs - #4519

Open
kj5248 wants to merge 2 commits into
mainfrom
jmatthews/4502-outdat-pf-coil-numbering
Open

Updated PF numbering in outputs#4519
kj5248 wants to merge 2 commits into
mainfrom
jmatthews/4502-outdat-pf-coil-numbering

Conversation

@kj5248

@kj5248 kj5248 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Description

closes #4502

In MFILE.DAT and OUT.DAT there were many places where PF coils were numbered from 0. This has been updated to start from 1.

Also in places such as Volt Second Consumption and Waveforms all the circuits were numbers, the final number has now shows CS as that's what it is. However in the PF Circuit Waveform Data section I left the circuit_var_name as the original as it is a var not an output name.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

… any CS coils labelled as PF 6 as CS in both MFILE.DAT and OUT.DAT
@kj5248
kj5248 requested a review from a team as a code owner August 13, 2026 10:19
@kj5248 kj5248 linked an issue Aug 13, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.29%. Comparing base (8fe9306) to head (131ccc6).

Files with missing lines Patch % Lines
process/models/pfcoil.py 0.00% 10 Missing ⚠️
process/core/io/plot/summary.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4519      +/-   ##
==========================================
- Coverage   49.30%   49.29%   -0.01%     
==========================================
  Files         150      150              
  Lines       29769    29775       +6     
==========================================
  Hits        14679    14679              
- Misses      15090    15096       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould
clmould requested a review from chris-ashe August 13, 2026 10:48
@clmould clmould self-assigned this Aug 13, 2026

@chris-ashe chris-ashe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kj5248 Have noticed that the coil numbering in the plots now starts from 2. Can you quickly update that to and I will take a full look after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OUT.DAT PF coil numbering

4 participants