Updated PF numbering in outputs - #4519
Open
kj5248 wants to merge 2 commits into
Open
Conversation
… any CS coils labelled as PF 6 as CS in both MFILE.DAT and OUT.DAT
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4519 +/- ##
==========================================
- Coverage 49.30% 49.29% -0.01%
==========================================
Files 150 150
Lines 29769 29775 +6
==========================================
Hits 14679 14679
- Misses 15090 15096 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
requested changes
Aug 13, 2026
chris-ashe
left a comment
Collaborator
There was a problem hiding this comment.
@kj5248 Have noticed that the coil numbering in the plots now starts from 2. Can you quickly update that to and I will take a full look after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #4502
In MFILE.DAT and OUT.DAT there were many places where PF coils were numbered from 0. This has been updated to start from 1.
Also in places such as Volt Second Consumption and Waveforms all the circuits were numbers, the final number has now shows CS as that's what it is. However in the PF Circuit Waveform Data section I left the circuit_var_name as the original as it is a var not an output name.
Checklist
I confirm that I have completed the following checks: