Skip to content

Rename solver vars to style guide - #4481

Merged
timothy-nunn merged 13 commits into
mainfrom
rename_solver_vars_to_style_guide
Aug 14, 2026
Merged

Rename solver vars to style guide#4481
timothy-nunn merged 13 commits into
mainfrom
rename_solver_vars_to_style_guide

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #4274

🔄 Renames

  • ioptimz -> i_process_run_mode
  • minmax -> i_figure_merit
  • neqns -> n_equality_constraints
  • nineqns -> n_inequality_constraints (shouldn't really be used in input files)

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe force-pushed the rename_solver_vars_to_style_guide branch 3 times, most recently from e9b124c to 91336fd Compare August 5, 2026 07:22
@chris-ashe
chris-ashe marked this pull request as ready for review August 5, 2026 07:23
@chris-ashe
chris-ashe requested a review from a team as a code owner August 5, 2026 07:23
@clmould clmould assigned clmould and timothy-nunn and unassigned clmould Aug 10, 2026
@chris-ashe
chris-ashe force-pushed the rename_solver_vars_to_style_guide branch from f610f7b to d4c3592 Compare August 14, 2026 09:27
@chris-ashe
chris-ashe force-pushed the rename_solver_vars_to_style_guide branch from bd9f49b to 391b5e6 Compare August 14, 2026 10:35
@chris-ashe
chris-ashe force-pushed the rename_solver_vars_to_style_guide branch from 391b5e6 to 169beb7 Compare August 14, 2026 10:46
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.12844% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (d353420) to head (169beb7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 0.00% 9 Missing ⚠️
process/core/caller.py 0.00% 8 Missing ⚠️
process/core/solver/solver_handler.py 0.00% 6 Missing ⚠️
process/core/io/in_dat/base.py 28.57% 5 Missing ⚠️
process/core/init.py 88.88% 3 Missing ⚠️
process/core/solver/constraints.py 0.00% 3 Missing ⚠️
process/core/solver/objectives.py 25.00% 3 Missing ⚠️
process/core/io/vary_run/tools.py 33.33% 2 Missing ⚠️
process/core/solver/evaluators.py 0.00% 2 Missing ⚠️
process/core/solver/solver.py 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4481   +/-   ##
=======================================
  Coverage   49.31%   49.32%           
=======================================
  Files         150      150           
  Lines       29769    29802   +33     
=======================================
+ Hits        14682    14700   +18     
- Misses      15087    15102   +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn merged commit c0ae5b2 into main Aug 14, 2026
8 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the rename_solver_vars_to_style_guide branch August 14, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants