Fix Stellarator regression failures

[timothy-nunn]

Reverts constraint 17 to pre-#4299.

The issue is that constraint 17 used to be formatted as

PROCESS/process/core/solver/constraints.py

Lines 594 to 605 in a68bb7f

	pradmaxpv = (
	data.current_drive.p_hcd_injected_total_mw / data.physics.vol_plasma
	+ data.physics.pden_alpha_total_mw * data.physics.f_p_alpha_plasma_deposited
	+ data.physics.pden_non_alpha_charged_mw
	+ data.physics.pden_plasma_ohmic_mw
	)
	return leq(
	data.physics.pden_plasma_rad_mw / pradmaxpv,
	data.constraints.fradpwr,
	constraint_registration,
	)

Importantly, it used pden_plasma_rad_mw. Now, the constraint uses f_p_plasma_separatrix_rad which is calculated as

PROCESS/process/models/physics/physics.py

Lines 1037 to 1042 in 024a2f2

	self.data.physics.f_p_plasma_separatrix_rad = (
	self.exhaust.calculate_radiation_fraction(
	p_plasma_rad_mw=self.data.physics.p_plasma_rad_mw,
	p_plasma_heating_mw=self.data.physics.p_plasma_heating_total_mw,
	)
	)

However this uses p_plasma_rad_mw which also includes the SOL radiation

PROCESS/process/models/stellarator/stellarator.py

Line 2170 in a68bb7f

self.data.physics.p_plasma_rad_mw += self.data.physics.psolradmw

which is never accounted for in pden_plasma_rad_mw. This changed the constraint, making the problem harder to solve, and led to constant failures when running the stellarator-helias test.

The diffs in the stellarator-helias test should revert it back to this file.

Thanks @clmould for identifying constraint 17 was the problem!

[chris-ashe]

Accidentally left in?

[timothy-nunn]

Yes :D

[chris-ashe]

Same here

[codecov-commenter]

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.82%. Comparing base (024a2f2) to head (d1b7773).

Files with missing lines	Patch %	Lines
process/models/stellarator/stellarator.py	0.00%	4 Missing ⚠️
process/core/solver/constraints.py	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4406      +/-   ##
==========================================
- Coverage   48.83%   48.82%   -0.01%     
==========================================
  Files         151      151              
  Lines       29397    29405       +8     
==========================================
+ Hits        14356    14358       +2     
- Misses      15041    15047       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.